Re: [PATCH] sparc: remove unused "config BITS"

From: Sam Ravnborg
Date: Tue Mar 19 2013 - 16:15:02 EST


On Tue, Mar 19, 2013 at 06:06:47PM +0100, Paul Bolle wrote:
> On Tue, 2013-03-19 at 12:33 -0400, David Miller wrote:
> > We use this in the Makefile fragments, you cannot remove it.
>
> >From arch/sparc/Makefile:
> ifeq ($(CONFIG_SPARC32),y)
> [...]
>
> [...]
> export BITS := 32
> [...]
>
> else
> [...]
>
> [...]
> export BITS := 64
> [...]
>
> So $(BITS) is set depending on whether CONFIG_SPARC32 is set or not.
> Using $(BITS) in sparc's Makefiles is not using CONFIG_BITS. That
> doesn't count as usage of "config BITS".
Just double checked - you are right.
Maybe send a v2 with this info in changelog and add my:

Acked-by: Sam Ravnborg <sam@xxxxxxxxxxxx>

Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/