Re: [PATCH 1/3] kernel/srcu: merge common code into a macro

From: Sebastian Andrzej Siewior
Date: Tue Mar 19 2013 - 14:16:08 EST


On 03/19/2013 05:22 PM, Joe Perches wrote:
>> +#define DEFINE_SRCU(name) _DEFINE_SRCU(name, )
>> +#define DEFINE_STATIC_SRCU(name) _DEFINE_SRCU(name, static)
>
> I think the use of an empty argument, even in
> a macro, unsightly.

__wait_event_lock_irq() => __wait_event_lock_irq() is a prominent user.
I would prefer to avoid adding something like /* nothing */.

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/