Re: [PATCH] ixp4xx_eth: set the device dma_coherent_mask

From: David Miller
Date: Tue Mar 19 2013 - 12:34:07 EST


From: Christophe Aeschlimann <aeschlimann@xxxxxxxxx>
Date: Tue, 19 Mar 2013 16:59:25 +0100

> Without the mask it is impossible to take the network interface up
> since it returns the following error:
>
>> net eth1: coherent DMA mask is unset
>> ifconfig: SIOCSIFFLAGS: Cannot allocate memory
>
> Tested on an out-of-tree ixp425 based board.
>
> Signed-off-by: Christophe Aeschlimann <c.aeschlimann@xxxxxxxxxxxx>
...
> @@ -1398,6 +1398,7 @@ static int eth_init_one(struct platform_device *pdev)
> return -ENOMEM;
>
> SET_NETDEV_DEV(dev, &pdev->dev);
> + dev->dev.coherent_dma_mask = DMA_BIT_MASK(32);

Hmmm, shouldn't this be the default value, set by the bus layer or
similar?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/