[tip:timers/core] tick: Provide a check for a forced broadcast pending

From: tip-bot for Thomas Gleixner
Date: Tue Mar 19 2013 - 07:39:42 EST

Commit-ID: eaa907c546f76222227dfc41784b22588af1e3d7
Gitweb: http://git.kernel.org/tip/eaa907c546f76222227dfc41784b22588af1e3d7
Author: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
AuthorDate: Wed, 6 Mar 2013 11:18:36 +0000
Committer: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
CommitDate: Wed, 13 Mar 2013 11:39:39 +0100

tick: Provide a check for a forced broadcast pending

On the CPU which gets woken along with the target CPU of the broadcast
the following happens:

<-- spurious wakeup
set forced bit

enable interrupts

<-- Nothing happens

disable interrupts

<-- Here we observe the forced bit is set

Now after that the target CPU of the broadcast runs the broadcast
handler and finds the other CPU in both the broadcast and the forced
mask, sends the IPI and stuff gets back to normal.

So it's not actually harmful, just more evidence for the theory, that
hardware designers have access to very special drug supplies.

Now there is no point in going back to deep idle just to wake up again
right away via an IPI. Provide a check which allows the idle code to
avoid the deep idle transition.

Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Cc: LAK <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>
Cc: John Stultz <john.stultz@xxxxxxxxxx>
Cc: Arjan van de Veen <arjan@xxxxxxxxxxxxx>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>
Tested-by: Santosh Shilimkar <santosh.shilimkar@xxxxxx>
Cc: Jason Liu <liu.h.jason@xxxxxxxxx>
Link: http://lkml.kernel.org/r/20130306111537.565418308@xxxxxxxxxxxxx
Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>

include/linux/clockchips.h | 6 ++++++
kernel/time/tick-broadcast.c | 12 ++++++++++++
2 files changed, 18 insertions(+)

diff --git a/include/linux/clockchips.h b/include/linux/clockchips.h
index 494d33e..646aac1 100644
--- a/include/linux/clockchips.h
+++ b/include/linux/clockchips.h
@@ -175,6 +175,12 @@ extern void tick_broadcast(const struct cpumask *mask);
extern int tick_receive_broadcast(void);

+extern int tick_check_broadcast_expired(void);
+static inline int tick_check_broadcast_expired(void) { return 0; }
extern void clockevents_notify(unsigned long reason, void *arg);
diff --git a/kernel/time/tick-broadcast.c b/kernel/time/tick-broadcast.c
index 2100aad..d76d816 100644
--- a/kernel/time/tick-broadcast.c
+++ b/kernel/time/tick-broadcast.c
@@ -404,6 +404,18 @@ struct cpumask *tick_get_broadcast_oneshot_mask(void)

+ * Called before going idle with interrupts disabled. Checks whether a
+ * broadcast event from the other core is about to happen. We detected
+ * that in tick_broadcast_oneshot_control(). The callsite can use this
+ * to avoid a deep idle transition as we are about to get the
+ * broadcast IPI right away.
+ */
+int tick_check_broadcast_expired(void)
+ return cpumask_test_cpu(smp_processor_id(), tick_broadcast_force_mask);
* Set broadcast interrupt affinity
static void tick_broadcast_set_affinity(struct clock_event_device *bc,
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/