Re: [PATCH 03/10] mm: vmscan: Flatten kswapd priority loop

[Mel Gorman]

On Tue, Mar 19, 2013 at 06:26:43PM +0800, Simon Jeons wrote:
> >>>-		if (sc.nr_reclaimed >= SWAP_CLUSTER_MAX)
> >>>-			break;
> >>>-	} while (--sc.priority >= 0);
> >>>+		if (order && sc.nr_reclaimed >= 2UL << order)
> >>>+			order = sc.order = 0;
> >>If order == 0 is meet, should we do defrag for it?
> >>
> >Compaction is unnecessary for order-0.
> >
> 
> I mean since order && sc.reclaimed >= 2UL << order, it is reclaimed
> for high order allocation, if order == 0 is meet, should we do
> defrag for it?
> 

I don't get this question at all. We do not defrag via compaction for
order-0 allocation requests because it makes no sense.

-- 
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/