Re: [PATCH 3/3] mm, nobootmem: do memset() after memblock_reserve()

From: Yinghai Lu
Date: Tue Mar 19 2013 - 01:53:11 EST


On Mon, Mar 18, 2013 at 10:16 PM, Joonsoo Kim <iamjoonsoo.kim@xxxxxxx> wrote:
> Currently, we do memset() before reserving the area.
> This may not cause any problem, but it is somewhat weird.
> So change execution order.
>
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx>
>
> diff --git a/mm/nobootmem.c b/mm/nobootmem.c
> index 589c673..f11ec1c 100644
> --- a/mm/nobootmem.c
> +++ b/mm/nobootmem.c
> @@ -46,8 +46,8 @@ static void * __init __alloc_memory_core_early(int nid, u64 size, u64 align,
> return NULL;
>
> ptr = phys_to_virt(addr);
> - memset(ptr, 0, size);
> memblock_reserve(addr, size);
> + memset(ptr, 0, size);

move down ptr = ... too ?

> /*
> * The min_count is set to 0 so that bootmem allocated blocks
> * are never reported as leaks.
> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/