Re: [PATCH 38/88] asus-laptop: Do not call HWRS on init

From: Ben Hutchings
Date: Mon Mar 18 2013 - 22:49:31 EST

On Thu, 2013-03-14 at 10:35 +0000, Luis Henriques wrote:
> -stable review patch. If anyone has any objections, please let me know.
> ------------------
> From: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> commit cb7da022450cdaaebd33078b6b32fb7dd2aaf6db upstream.
> Since commit 8871e99f89b7 ('asus-laptop: HRWS/HWRS typo'), module
> initialisation is very slow on the Asus UL30A. The HWRS method takes
> about 12 seconds to run, and subsequent initialisation also seems to
> be delayed. Since we don't really need the result, don't bother
> calling it on init. Those who are curious can still get the result
> through the 'infos' device attribute.
> Update the comment about HWRS in show_infos().
> Reported-by: ryan <draziw+deb@xxxxxxxxx>
> References:
> Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> Signed-off-by: Corentin Chary <corentin.chary@xxxxxxxxx>
> Signed-off-by: Matthew Garrett <matthew.garrett@xxxxxxxxxx>
> Signed-off-by: Luis Henriques <luis.henriques@xxxxxxxxxxxxx>

Ironically I forgot to cc:stable on this one. Please add it to 3.0.y
and 3.4.y, which also got backports of commit 8871e99f89b7.


Ben Hutchings
When you say `I wrote a program that crashed Windows', people just stare ...
and say `Hey, I got those with the system, *for free*'. - Linus Torvalds

Attachment: signature.asc
Description: This is a digitally signed message part