Re: [PATCH 2/9] migrate: make core migration code aware of hugepage

From: Michal Hocko
Date: Mon Mar 18 2013 - 11:22:31 EST


On Thu 21-02-13 14:41:41, Naoya Horiguchi wrote:
[...]
> diff --git v3.8.orig/include/linux/mempolicy.h v3.8/include/linux/mempolicy.h
> index 0d7df39..2e475b5 100644
> --- v3.8.orig/include/linux/mempolicy.h
> +++ v3.8/include/linux/mempolicy.h
> @@ -173,7 +173,7 @@ extern int mpol_to_str(char *buffer, int maxlen, struct mempolicy *pol);
> /* Check if a vma is migratable */
> static inline int vma_migratable(struct vm_area_struct *vma)
> {
> - if (vma->vm_flags & (VM_IO | VM_HUGETLB | VM_PFNMAP))
> + if (vma->vm_flags & (VM_IO | VM_PFNMAP))
> return 0;

Is this safe? At least check_*_range don't seem to be hugetlb aware.

--
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/