Re: [PATCH] perf: fix ring_buffer perf_output_space() boundarycalculation

[Peter Zijlstra]

On Mon, 2013-03-18 at 13:48 +0100, Stephane Eranian wrote:
>         if (!rb->writable)
> -               return true;
> +               return false;


writable means user writable (VM_WRITE); the difference is that a
!VM_WRITE buffer will simply over-write its own tail whereas a VM_WRITE
buffer will drop events.

So returning true for !VM_WRITE makes sense, there's always space.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/