Re: [PATCH 13/19] f2fs: fix return value of releasepage for node and data

[Namjae Jeon]

2013/3/18, Jaegeuk Kim <jaegeuk.kim@xxxxxxxxxxx>:
> If the return value of releasepage is equal to zero, the page cannot be
> reclaimed.
> Instead, we should return 1 in order to reclaim clean pages.
>
> Signed-off-by: Jaegeuk Kim <jaegeuk.kim@xxxxxxxxxxx>
> ---
>  fs/f2fs/data.c |  4 +++-
>  fs/f2fs/node.c | 13 +++----------
>  2 files changed, 6 insertions(+), 11 deletions(-)
>
> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
> index 6616137..cd6b2cc 100644
> --- a/fs/f2fs/data.c
> +++ b/fs/f2fs/data.c
> @@ -680,8 +680,10 @@ static void f2fs_invalidate_data_page(struct page
> *page, unsigned long offset)
>
>  static int f2fs_release_data_page(struct page *page, gfp_t wait)
>  {
> +	if (PageWriteback(page))
> +		return 0;
>  	ClearPagePrivate(page);
> -	return 0;
> +	return 1;
>  }
I have a question.
Although PageWriteback is already checked in try_to_release_page,
we need to check it again in f2fs_release_data_page ?

Thanks.


> 1.8.1.3.566.gaa39828
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/