Re: [PATCH v6 1/2] ARM: davinci: dm365: add support for v4l2 videodisplay

[Sekhar Nori]

On 3/18/2013 2:46 PM, Prabhakar Lad wrote:
> On Mon, Mar 18, 2013 at 1:48 PM, Sekhar Nori <nsekhar@xxxxxx> wrote:
>> On 3/15/2013 8:41 PM, Prabhakar lad wrote:

>>> +int __init dm365_init_video(struct vpfe_config *vpfe_cfg,
>>> +                             struct vpbe_config *vpbe_cfg)
>>> +{
>>> +     if (vpfe_cfg || vpbe_cfg)
>>> +             platform_device_register(&dm365_vpss_device);
>>> +
>>> +     if (vpfe_cfg) {
>>> +             vpfe_capture_dev.dev.platform_data = vpfe_cfg;
>>> +             /* Add isif clock alias */
>>
>> This comment is useless. Instead please document why the aliases are
>> needed. I know you are just moving code here, but lets do a clean-up job
>> while at it.
>>
> by document you mean to add a file in Documentation folder ?

No, just modify the comment to talk about why the aliases are needed.

Thanks,
Sekhar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/