Re: [PATCH] perf cgroup: Add __percpu annotation to perf_cgroup->info

[Ingo Molnar]

* Namhyung Kim <namhyung@xxxxxxxxxx> wrote:

> From: Namhyung Kim <namhyung.kim@xxxxxxx>
> 
> It's a per-cpu data structure but missed the __percpu annotation.
> 
> Cc: Tejun Heo <tj@xxxxxxxxxx>
> Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>
> ---
>  include/linux/perf_event.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
> index 001a3b64fe61..16116aee9405 100644
> --- a/include/linux/perf_event.h
> +++ b/include/linux/perf_event.h
> @@ -311,8 +311,8 @@ struct perf_cgroup_info {
>  };
>  
>  struct perf_cgroup {
> -	struct				cgroup_subsys_state css;
> -	struct				perf_cgroup_info *info;	/* timing info, one per cpu */
> +	struct cgroup_subsys_state 	css;
> +	struct perf_cgroup_info __percpu * info;
>  };
>  #endif

Would be nice to have this against tip:master - 'struct perf_cgroup' 
recently moved to kernel/events/, in the development tree.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/