Re: [PATCH v2 1/3] ACPI video: Fix brightness control initializationfor some laptops.

From: Danny Baumann
Date: Mon Mar 18 2013 - 04:22:32 EST


Hi,

diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index 313f959..9c33871 100644
--- a/drivers/acpi/video.c
+++ b/drivers/acpi/video.c
@@ -222,7 +222,7 @@ static int acpi_video_device_lcd_set_level(struct acpi_video_device *device,
int level);
static int acpi_video_device_lcd_get_level_current(
struct acpi_video_device *device,
- unsigned long long *level, int init);
+ unsigned long long *level, int raw);

Why not bool?

For two reasons:
- It previous was int ;-)
- It allowed the invocations of this function to fit within one 80-char line.

Neither reason is terribly strong, so if you prefer, I can convert this argument to bool.

Regards,

Danny
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/