Re: [PATCH] Revert "drm/i915: try to train DP even harder"

From: Daniel Vetter
Date: Sun Mar 17 2013 - 17:56:46 EST


On Mon, Mar 11, 2013 at 06:40:16PM +0100, Takashi Iwai wrote:
> This reverts commit 0d71068835e2610576d369d6d4cbf90e0f802a71.
>
> Not only that the commit introduces a bogus check (voltage_tries == 5
> will never meet at the inserted code path), it brings the i915 driver
> into an endless dp-train loop on HP Z1 desktop machine with IVY+eDP.
>
> At least reverting this commit recovers the framebuffer (but X is
> still broken by other reasons...)
>
> Cc: <stable@xxxxxxxxxxxxxxx>
> Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>
Picked up for -fixes, thanks for the patch. Adding Paulo since it's his
patch. To assign proper blame please cc: relevant people when sending out
reverts.

Thanks, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/