Re: [PATCH 33/50] staging: omap-thermal: refactor APIs handling thresholdvalues

[Eduardo Valentin]

On 16-03-2013 04:39, Dan Carpenter wrote:
> On Fri, Mar 15, 2013 at 09:00:21AM -0400, Eduardo Valentin wrote:
> >   	if (ret) {
> >   		dev_err(bg_ptr->dev, "failed to read thot\n");
> > -		return -EIO;
> > +		ret = -EIO;
> > +		goto exit;
> >   	}
> >
> > -	*thot = temp;
> > +	*val = temp;
> >
> > +exit:
> >   	return 0;
> >   }
>
>
> The bunny hop has introduced a bug and this always returns success.

What was the bug introduced?

I will send a patch to fix the return value.

> regards,
> dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/