Re: [PATCH v2, part2 08/10] mm/SPARC: use free_highmem_page() tofree highmem pages into buddy system

From: Andrew Morton
Date: Tue Mar 12 2013 - 17:42:21 EST


On Sun, 10 Mar 2013 16:01:08 +0800 Jiang Liu <liuj97@xxxxxxxxx> wrote:

> Use helper function free_highmem_page() to free highmem pages into
> the buddy system.
>
> ...
>
> --- a/arch/sparc/mm/init_32.c
> +++ b/arch/sparc/mm/init_32.c
> @@ -282,14 +282,8 @@ static void map_high_region(unsigned long start_pfn, unsigned long end_pfn)
> printk("mapping high region %08lx - %08lx\n", start_pfn, end_pfn);
> #endif
>
> - for (tmp = start_pfn; tmp < end_pfn; tmp++) {
> - struct page *page = pfn_to_page(tmp);
> -
> - ClearPageReserved(page);
> - init_page_count(page);
> - __free_page(page);
> - totalhigh_pages++;
> - }
> + for (tmp = start_pfn; tmp < end_pfn; tmp++)
> + free_higmem_page(pfn_to_page(tmp));
> }

This code isn't inside #ifdef CONFIG_HIGHMEM, but afaict that's OK
because CONFIG_HIGHMEM=n isn't possible on sparc32.

This patch and one other mistyped "free_highmem_page". I got lazy and
edited those patches in-place.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/