Re: [PATCHSET] writeback: convert writeback to unbound workqueue

From: Jens Axboe
Date: Tue Mar 12 2013 - 11:07:19 EST

On Thu, Mar 07 2013, Tejun Heo wrote:
> Hello,
> There's no reason for writeback to implement its own worker pool when
> using workqueue is much simpler and more efficient. This patchset
> replaces writeback's custom worker pool with unbound workqueue and
> also exports it to userland using WQ_SYSFS so that it can be tuned
> from userland as requested a couple releases ago.
> This patchset contains the following four patches.
> 0001-implement-current_is_workqueue_rescuer.patch
> 0002-writeback-remove-unused-bdi_pending_list.patch
> 0003-writeback-replace-custom-worker-pool-implementation-.patch
> 0004-writeback-expose-the-bdi_wq-workqueue.patch
> 0001-0002 are prep patches. 0003 does the conversion. 0004 makes
> bdi_wq visible to userland.
> This patchset is on top of v3.9-rc1 + "workqueue: implement workqueue
> with custom worker attributes" patchset[1] and available in the
> following git branch.
> git:// review-writeback-conversion

I like it, diffstat looks nice too :-)

Have you done any performance testing, or just functional verification?

Jens Axboe

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at