Re: [PATCH V2 2/5] rtc: tegra: Use struct dev_pm_ops for power management

[Laxman Dewangan]

On Monday 11 March 2013 10:48 PM, Stephen Warren wrote:
> On 03/11/2013 02:56 AM, Laxman Dewangan wrote:
> > On Monday 11 March 2013 02:21 PM, Thierry Reding wrote:
> > > * PGP Signed by an unknown key
> > >
> > > On Mon, Mar 11, 2013 at 02:14:25PM +0530, Laxman Dewangan wrote:
> > > [...]
> > > > diff --git a/drivers/rtc/rtc-tegra.c b/drivers/rtc/rtc-tegra.c
> > > [...]
> > > > @@ -431,6 +430,8 @@ static int tegra_rtc_resume(struct
> > > > platform_device *pdev)
> > > >    }
> > > >    #endif
> > > >    +SIMPLE_DEV_PM_OPS(tegra_rtc_pm_ops, tegra_rtc_suspend,
> > > > tegra_rtc_resume);
> > > I should've been more explicit. Since you had this marked as static in
> > > the previous patch, this needs to be static SIMPLE_DEV_PM_OPS.
> > Yaah, I should keep the static.
> >
> > I think I will need to respin this patch only in place of whole series.
> >
> > Andrew,
> >
> > Let me know if this is fine.
> In general, it's much easier if you repost a whole series. Otherwise,
> you make the maintainer manually piece together the series from bits of
> V2 and bits of V3, which is harder than just grabbing all of V3.

yaah, this will be easy. I will respin 3rd version.

Thanks,
Laxman


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/