Re: [PATCH 17/31] workqueue: implement attribute-based unboundworker_pool management

[Tejun Heo]

On Sun, Mar 10, 2013 at 05:58:21AM -0700, Tejun Heo wrote:
> > > +	if (WARN_ON(pool->nr_workers != pool->nr_idle))
> > > +		return;
> > 
> > This can be false-negative. we should remove this WARN_ON().
> 
> How would the test fail spuriously?  Can you please elaborate?

I got it.  It'll be short by one if there's an active manager.
Removed.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/