Re: [PATCH 05/10] dmatest: split test parameters to separatestructure

From: Andy Shevchenko
Date: Fri Mar 08 2013 - 08:08:08 EST


On Tue, 2013-03-05 at 17:16 +0800, Viresh Kumar wrote:
> On 4 March 2013 17:09, Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > Better to keep test parameters separate from internal variables.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > ---
> > drivers/dma/dmatest.c | 109 ++++++++++++++++++++++++++++----------------------
> > 1 file changed, 62 insertions(+), 47 deletions(-)
>
> Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
>
> Though i don't feel a real need of keeping this in separate patches.
> We can have one for fixing these :)

Do you mean to merge patche 3,4, and 5 into one?


--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/