Re: [PATCH v2] early_printk: consolidate random copies of identicalcode

[Andrew Morton]

On Thu, 7 Mar 2013 22:25:48 +0100 (CET) Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:

> > diff --git a/kernel/printk.c b/kernel/printk.c
> > index 7664e49..86799bf 100644
> > --- a/kernel/printk.c
> > +++ b/kernel/printk.c
> > @@ -120,6 +120,7 @@ struct console_cmdline
> >  static struct console_cmdline console_cmdline[MAX_CMDLINECONSOLES];
> >  static int selected_console = -1;
> >  static int preferred_console = -1;
> > +struct console *early_console;
> >  int console_set_on_cmdline;
> >  EXPORT_SYMBOL(console_set_on_cmdline);
> >  
> > @@ -1718,7 +1719,6 @@ static size_t cont_print_text(char *text, size_t size) { return 0; }
> >  #endif /* CONFIG_PRINTK */
> >  
> >  #ifdef CONFIG_EARLY_PRINTK
> > -struct console *early_console;
> >  
> >  void early_vprintk(const char *fmt, va_list ap)
> >  {
> > 
> > 
> > Then you don't have to spray any of those ifdefs into the sparc code.
> 
> Yeah, that's what I thought as well. The extra pointer is not going to
> create massive bloat :)

It's a bit hacky though.  If CONFIG_EARLY_PRINTK=n then that code just
shouldn't exist.  If we let it persist then maybe it's doing other
wrong stuff as well.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/