Re: [PATCH] cpufreq: ARM big LITTLE: Add generic cpufreq driverand its DT glue

From: Russell King - ARM Linux
Date: Wed Mar 06 2013 - 19:51:44 EST


On Thu, Mar 07, 2013 at 08:32:37AM +0800, Viresh Kumar wrote:
> On 5 March 2013 18:52, Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> wrote:
> > On Tue, Mar 05, 2013 at 12:52:41PM +0800, Viresh Kumar wrote:
> >> + clk[cluster] = clk_get(NULL, name);
> >> + if (!IS_ERR_OR_NULL(clk[cluster])) {
> >
> > NAK. Two reasons.
> >
> > 1. IS_ERR_OR_NULL. You know about this, it's been on the list several
> > times.
>
> Hey, i had a second thought about this one and i have some other opinion
> here. This is a cpufreq driver and we need clock support for sure here, we
> can't work without it. And so here is the latest fixup:

NAK. You just don't understand.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/