RE: [PATCH] clk: tegra: provide dummy cpu car ops

[Andrew Chew]

> Subject: [PATCH] clk: tegra: provide dummy cpu car ops
> 
> tegra_boot_secondary() relies on some of the car ops. This means having an
> uninitialized tegra_cpu_car_ops will lead to an early boot panic.
> Providing a dummy struct avoids this and makes adding Tegra114 clock
> support in a bisectable way a lot easier.
> 
> --
> 
> Stephen,
> 
> Should this be a separate patch or should I make this part of new release of
> the Tegra114 clock series?
> 
> Signed-off-by: Peter De Schrijver <pdeschrijver@xxxxxxxxxx>
> ---
>  drivers/clk/tegra/clk.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/clk/tegra/clk.c b/drivers/clk/tegra/clk.c index
> a603b9a..f6c141f 100644
> --- a/drivers/clk/tegra/clk.c
> +++ b/drivers/clk/tegra/clk.c
> @@ -22,7 +22,8 @@
>  #include "clk.h"
> 
>  /* Global data of Tegra CPU CAR ops */
> -struct tegra_cpu_car_ops *tegra_cpu_car_ops;

Sorry for bringing this up so late...
Shouldn't the above be "struct tegra_cpu_car_ops tegra_cpu_car_ops;"?

> +static struct tegra_cpu_car_ops *dummy_car_ops; struct
> +tegra_cpu_car_ops *tegra_cpu_car_ops = &dummy_car_ops;
> 
>  void __init tegra_init_dup_clks(struct tegra_clk_duplicate *dup_list,
>  				struct clk *clks[], int clk_max)
> --
> 1.7.7.rc0.72.g4b5ea.dirty
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the
> body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at
> http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/