Re: [PATCH] efivarfs: fix abnormal GUID in variable name by usingstrcpy to replace null with dash

From: Frederic Crozat
Date: Wed Mar 06 2013 - 08:30:48 EST


Le mercredi 06 mars 2013 Ã 12:36 +0000, Matt Fleming a Ãcrit :
> On Wed, 2013-03-06 at 12:58 +0100, Frederic Crozat wrote:
> > Le mercredi 06 mars 2013 Ã 11:19 +0000, Matt Fleming a Ãcrit :
> >
> > > Also, which machine did you see this behaviour on?
> >
> > HP z220 desktop, System BIOS K51 v 1.54
> >
> > this issue is only the "Secure Boot" related variables, which make me
> > think HP incorrectly created them in their latest firmware (where they
> > added Windows 8 support).
>
> Are you saying that the behaviour regarding VariableNameSize changes
> depending on which variable is returned?
>
> Mercy.....

Well, I only get the error message for some variables (8), not all of
them.

It was quite visible on unpatched kernel, with ls
-d /sys/firmware/efi/vars.

ls -d /sys/firmware/efi/vars/*8be4d* | grep -v -- -8be returns
/sys/firmware/efi/vars/dbxDefault-pport8be4df61-93ca-11d2-aa0d-00e098032b8c
/sys/firmware/efi/vars/KEKDefault-pport8be4df61-93ca-11d2-aa0d-00e098032b8c
/sys/firmware/efi/vars/SecureBoot-pport8be4df61-93ca-11d2-aa0d-00e098032b8c
/sys/firmware/efi/vars/SetupMode-Information8be4df61-93ca-11d2-aa0d-00e098032b8c
/sys/firmware/efi/vars/SignatureSupport-pport8be4df61-93ca-11d2-aa0d-00e098032b8c
/sys/firmware/efi/vars/VendorKeys-pport8be4df61-93ca-11d2-aa0d-00e098032b8c

All other variable names were fine.
--
Frederic Crozat <fcrozat@xxxxxxxx>
SUSE

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/