Re: [PATCH 5/9] ARM: omap1: add back missing includes

From: Arnd Bergmann
Date: Wed Mar 06 2013 - 06:23:44 EST


On Wednesday 06 March 2013, Tony Lindgren wrote:
> * Arnd Bergmann <arnd@xxxxxxxx> [130305 14:31]:
> > On Tuesday 05 March 2013, Arnd Bergmann wrote:
> > > The recent reorganization of OMAP header files caused a couple of
> > > files that used to be implicitly included now missing from OMAP1.
> > > This adds explicit inclusions of mach/irqs.h and mach/hardware.h
> > > in all files that need them for an OMAP1 allyesconfig build.
> > >
> > > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> > > Cc: Tony Lindgren <tony@xxxxxxxxxxx>
> > > Cc: linux-omap@xxxxxxxxxxxxxxx
> > > ---
> > > arch/arm/mach-omap1/board-fsample.c | 1 +
> > > arch/arm/mach-omap1/board-h2.c | 1 +
> > > arch/arm/mach-omap1/board-perseus2.c | 1 +
> > > arch/arm/mach-omap1/board-sx1.c | 1 +
> > > drivers/video/omap/lcd_ams_delta.c | 1 +
> > > drivers/video/omap/lcd_osk.c | 1 +
> > > 6 files changed, 6 insertions(+)
> >
> > I saw that Tony has already addressed the latter two changes, but
> > did not see a fix for the four board files.
>
> Hmm I wonder why I have not seen the board-*.c related ones?
>
> Anyways thanks for fixing those:
>
> Acked-by: Tony Lindgren <tony@xxxxxxxxxxx>

Actually I cannot reproduce them myself now, I think I'll just drop
the patch for now, but will remember your Ack if the problem comes
back. The patch would be needed if we decide to use SPARSE_IRQ on
OMAP1.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/