Re: [PATCH v3 -next 0/5] Add support for LZ4-compressed kernel

From: Kyungsik Lee
Date: Wed Mar 06 2013 - 01:15:15 EST


On Tue, Mar 05, 2013 at 03:06:16PM -0800, Andrew Morton wrote:
> On Tue, 5 Mar 2013 20:47:31 +0900 Kyungsik Lee <kyungsik.lee@xxxxxxx> wrote:
>
> > This is the third version. In this version, Some codes are fixed
> > and more description and note are added. I would like to thank David Sterba
> > for his review.
> >
> > The Last patch[5/5] of the patch set is for making x86 and arm default to
> > LZ4-compressed for testing the LZ4 code in the linux-next.
> > It was requested by Andrew Morton in the patch set v2.
> >
> > Currently, A preliminary version of LZ4 de/compression tool is supported.
> > However, It is expected that we will have a tool with more features
> > once its format is finished.
>
> What happened to the changelog? The earlier version at least had some
> rudimentary benchmarking results, but now we don't even have that.
>
> Someone should prepare the information explaining why we added this to
> Linux, and I'd prefer that person be you rather than me! Certainly it
> should include performance measurements - both speed and space. Also
> it should capture our thinking regarding all the other decompressors,
> explaining why we view it as acceptable to add yet another one.
Sorry, It will have all the information you mentioned. I can reply to
this thread if you want.

Or I might need another patch(v4). I have one thing to be confirmed
regarding LZ4 format. One of the patch set needs to be fixed
if there is a change. After that I can include the information
in the changelog.

> Please, put yourself in the position of someone reading these commits
> in 2017 wondering "why did they merge this". We should tell them.

Thanks,
Kyungsik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/