Re: [PATCH v3 3/3] leds: leds-pwm: Defer led_pwm_set() if PWM cansleep

From: Florian Vaussard
Date: Tue Mar 05 2013 - 10:39:30 EST



On 03/04/2013 11:58 AM, Thierry Reding wrote:
On Mon, Mar 04, 2013 at 11:44:22AM +0100, Florian Vaussard wrote:
Hi Bryan, Richard,

On 01/30/2013 09:17 AM, Thierry Reding wrote:
On Mon, Jan 28, 2013 at 03:00:59PM +0100, Florian Vaussard wrote:
Call to led_pwm_set() can happen inside atomic context, like triggers.
If the PWM call can sleep, defer using a worker.

Cc: Peter Ujfalusi <peter.ujfalusi@xxxxxx>
Signed-off-by: Florian Vaussard <florian.vaussard@xxxxxxx>
---
drivers/leds/leds-pwm.c | 50
+++++++++++++++++++++++++++++++++++++++-------
1 files changed, 42 insertions(+), 8 deletions(-)

Bryan, I assume that you'll be taking this? It doesn't apply cleanly to
my tree, probably because of Peter's recent changes that you took
through your tree and Florian based his patches on top of that. The
conflict resolution should be trivial, though.


It seems that this patch was not taken. Could you pull it, as the other
part is already in linux-pwm? Or is there any show stopper?


Ping? Who should merge this?

I assume Bryan will take it through the LED tree? Patches 1 & 2 went
into v3.9-rc1 through the PWM tree.


This was also my assumption, but I never got the feedback from Brian on this patch.
The crach is still there, and the patch missed the merge window :)

Cheers,

Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/