Re: [PATCH] usb/gadget: initialize gadget functions helper beforfunctions & gadgets

From: Fengguang Wu
Date: Tue Mar 05 2013 - 05:35:33 EST


On Tue, Mar 05, 2013 at 05:57:34PM +0800, Fengguang Wu wrote:
> On Mon, Mar 04, 2013 at 10:28:09PM +0100, Sebastian Andrzej Siewior wrote:
> > Fengguang Wu run into a kernel ops after he complied dummy_hcd and g_cdc
> > into the kernel. The problem was that u_serial was used by g_cdc before
> > u_serial was initialized. In the module case eveything is initialized in
> > the correct order but if we compile it into the kernel we rely on
> > Makefile order which I did wrong and now I correct this.
> >
> > Cc: Fengguang Wu <fengguang.wu@xxxxxxxxx>
> > Signed-off-by: Sebastian Andrzej Siewior <sebastian@xxxxxxxxxxxxx>
>
> Tested-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>

Note that I still get this warning, however looks like an unrelated
issue:

[ 602.536679] [ INFO: possible circular locking dependency detected ]
[ 602.536672]
[ 602.536679] ======================================================
[ 602.536679] [ INFO: possible circular locking dependency detected ]
[ 602.536693] 3.8.0-bisect-next-20130301-dirty #212 Not tainted
[ 602.536694] -------------------------------------------------------
[ 602.536698] kworker/0:1/27 is trying to acquire lock:
[ 602.536750] (&fb_info->lock){+.+.+.}, at: [<ffffffff814c0176>] lock_fb_info+0x26/0x60
[ 602.536751]
[ 602.536751] but task is already holding lock:
[ 602.536773] (console_lock){+.+.+.}, at: [<ffffffff815a6a13>] console_callback+0x13/0x150
[ 602.536774]
[ 602.536774] which lock already depends on the new lock.

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/