Re: [PATCH 11/11] zcache/zbud: Add incremental accessory counters

[Greg KH]

On Mon, Mar 04, 2013 at 01:18:21PM -0500, Konrad Rzeszutek Wilk wrote:
> that are going to be used for debug fs entries.

what debugfs entries?

> 
> Acked-by: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> ---
>  drivers/staging/zcache/zbud.c | 58 +++++++++++++++++++++++++++++--------------
>  1 file changed, 39 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/staging/zcache/zbud.c b/drivers/staging/zcache/zbud.c
> index fdff5c6..0feb856 100644
> --- a/drivers/staging/zcache/zbud.c
> +++ b/drivers/staging/zcache/zbud.c
> @@ -301,6 +301,26 @@ static ssize_t zbud_eph_unbuddied_count;
>  static ssize_t zbud_pers_unbuddied_count;
>  static ssize_t zbud_eph_zombie_count;
>  static ssize_t zbud_pers_zombie_count;
> +static inline void inc_zbud_eph_pageframes(void) { zbud_eph_pageframes++; };
> +static inline void inc_zbud_pers_pageframes(void) { zbud_pers_pageframes++; };
> +static inline void inc_zbud_eph_zpages(void) { zbud_eph_zpages++; };

<snip>

That's just insane, why are you doing this?

As you aren't using this yet, I'm not going to apply this patch, sorry.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/