Re: [PATCH 2/3] irq: Add hw continuous IRQs map to virtual continuousIRQs support

[Mike Qiu]

ä 2013/3/5 10:41, Paul Mundt åé:
> On Tue, Jan 15, 2013 at 03:38:55PM +0800, Mike Qiu wrote:
> > Adding a function irq_create_mapping_many() which can associate
> > multiple MSIs to a continous irq mapping.
> >
> > This is needed to enable multiple MSI support for pSeries.
> >
> > +int irq_create_mapping_many(struct irq_domain *domain,
> > +		irq_hw_number_t hwirq_base, int count)
> > +{
> Other than the other review comments already made, I think you can
> simplify this considerably by simply doing what irq_create_strict_mappings() does,
> and relaxing the irq_base requirements.
>
> In any event, as you are creating a new interface, I don't think you want
> to carry around half of the legacy crap that irq_create_mapping() has to
> deal with. We made the decision to avoid this with irq_create_strict_mappings()
> intentionally, too.
Oh, yes, you are right, I will send out V2 of my patch to make it more 
comfortable , and hope you can review my patch again

Thanks

Mike

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/