Re: [PATCH] md/raid456: remove depends on CONFIG_EXPERIMENTAL

From: Kees Cook
Date: Mon Mar 04 2013 - 16:13:38 EST


On Mon, Mar 4, 2013 at 1:11 PM, NeilBrown <neilb@xxxxxxx> wrote:
> On Mon, 4 Mar 2013 10:59:30 -0800 Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>
>> On Tue, Feb 26, 2013 at 5:27 PM, Dan Williams <djbw@xxxxxx> wrote:
>> > On Fri, Feb 22, 2013 at 11:40 PM, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>> >> The CONFIG_EXPERIMENTAL config item has not carried much meaning for a
>> >> while now and is almost always enabled by default. As agreed during the
>> >> Linux kernel summit, remove it from any "depends on" lines in Kconfigs.
>> >>
>> >> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
>> >> Cc: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>
>> >> Cc: Dan Williams <dan.j.williams@xxxxxxxxx>
>> >> Cc: Alasdair G Kergon <agk@xxxxxxxxxx>
>> >> ---
>> >> drivers/md/Kconfig | 1 -
>> >> 1 file changed, 1 deletion(-)
>> >>
>> >> diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig
>> >> index 7cdf359..0cc3a3d 100644
>> >> --- a/drivers/md/Kconfig
>> >> +++ b/drivers/md/Kconfig
>> >> @@ -158,7 +158,6 @@ config MULTICORE_RAID456
>> >> bool "RAID-4/RAID-5/RAID-6 Multicore processing (EXPERIMENTAL)"
>> >> depends on MD_RAID456
>> >> depends on SMP
>> >> - depends on EXPERIMENTAL
>> >
>> > In this case MULTICORE_RAID456 and the related code should go as
>> > well... now that there are patches to supersede this implementation in
>> > md-next.
>>
>> Can my original patch go through as-is for Linus's tree? Right now,
>> this is the last use of EXPERIMENTAL in v3.9-rc1. If we can drop it,
>> we can remove the config item entirely from v3.9.
>
> My pull request which removes CONFIG_MULTICORE_RAID456 completely was a little
> late and missed -rc1. Hopefully it will appear soon.
> But if it isn't gone by -rc2, I have no objection to your patch going in then.

Ah-ha! Okay, it sounded like the other stuff was scheduled for 3.10.
If it's going into 3.9, then I'll just wait for -rc2 before pushing
the final removal patch.

Thanks!

-Kees

--
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/