Re: LOCKDEP: 3.9-rc1: mount.nfs/4272 still has locks held!

[Oleg Nesterov]

On 03/04, Mandeep Singh Baines wrote:
>
> The problem is that freezer_count() calls try_to_freeze(). In this
> case, try_to_freeze() is not really adding any value.

Well, I tend to agree.

If a task calls __refrigerator() holding a lock which another freezable
task can wait for, this is not freezer-friendly.

freezable_schedule/freezer_do_not_count/etc not only means "I won't be
active if freezing()", it should also mean "I won't block suspend/etc".

OTOH, I understand that probably it is not trivial to change this code
to make it freezer-friendly. But at least  I disagree with "push your
problems onto others".

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/