Re: [PATCH 4/4] power: tps65090: Add support for tps65090-charger

[Rhyland Klein]

On 3/2/2013 7:03 PM, Anton Vorontsov wrote:
> Hello Rhyland,
>
> Thanks for the driver! A few comments down below...
>
> On Wed, Feb 27, 2013 at 06:07:30PM -0500, Rhyland Klein wrote:
> > This patch adds support for the tps65090 charger driver.
> Would be nice to get a few more words about the hardware and the driver.
> Why it is cool, main features, what is missing (if any), what is planned.

Yah, this is really a child driver of the tps65090 mfd chip, so a lot of 
the driver coolness
is already defined there :) I'll look into the hw some and see what 
other coolness might
be possible to add around here :)

> ...
> +
> +     irq = platform_get_irq(pdev, 0);
> +     if (irq <= 0) {
> +             dev_warn(&pdev->dev, "Unable to get charger irq = %d\n", irq);
> +             return irq;
> +     }
> +
> +     ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
> +             tps65090_charger_isr, 0, "tps65090-charger", charger_data);
> You should request irq after power_supply object (and charger_data) are
> fully usable. Otherwise, if irq suddenly comes midway in the registration
> process, we'll get an oops.

Yah the first time I looked at this the order struck me as kinda off, 
but I guess I got
sidetracked and forgot to go back to it. Thanks for catching this!

-rhyland

--
nvpublic

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/