Re: [PATCH V3 1/3] mtd: add new fields to nand_flash_dev{}

[Huang Shijie]

ä 2013å03æ04æ 15:50, Artem Bityutskiy åé:
> On Mon, 2013-03-04 at 13:57 +0800, Huang Shijie wrote:
> > The current code uses the @id to store the device id(byte 1).
> > But if we use the 8 bytes id data as the keyword, and expand the @id
> > field to 8byte array,
> > the device id is the second byte now. All the added zeros are for the
> I do not think you need to store the full array of ID's. Device ID's for
> all the 4 of above chips are different, which is enough to distinguish
> between them.
>
> The only thing you need to add is the OOB size field to 'struct
> nand_flash_dev'.
If i only add the oob size field. There will be two items with the same 
Device ID in nand_flash_ids table,
one has oob_size, one does not have. such as:

   {"NAND 8GIB 3,3V 8-bit", 0xDE, 0, 8192, 0, LP_OPTIONS},
   {"NAND 8GIB 3,3V 8-bit", 0xDE, 0, 8192, 0, LP_OPTIONS, 640},   //OOB 
size is 640.


How can i distinguish them? In which case, i choose the item with the 
oob_size, and in which case, i choose
the item without the oobsize?

thanks
Huang Shijie






--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/