Re: [ 093/153] ALSA: hda - hdmi: Make jacks phantom, if theyre notdetectable

[David Henningsson]

On 03/04/2013 08:48 AM, Greg Kroah-Hartman wrote:
> On Mon, Mar 04, 2013 at 08:46:16AM +0100, David Henningsson wrote:
> > On 03/04/2013 06:13 AM, Ben Hutchings wrote:
> > > On Mon, 2013-03-04 at 03:38 +0000, Ben Hutchings wrote:
> > > > 3.2-stable review patch.  If anyone has any objections, please let me know.
> > > >
> > > > ------------------
> > > >
> > > > From: David Henningsson <david.henningsson@xxxxxxxxxxxxx>
> > > >
> > > > commit 30efd8debd1ef30be342d374f01e993509f5b76b upstream.
> > > >
> > > > Just as for analog codecs, a jack that isn't suitable for detection
> > > > (in this case, NO_PRESENCE was set) should be a phantom Jack
> > > > instead of a normal one.
> > > >
> > > > Thanks to Raymond Yau for spotting.
> > > >
> > > > BugLink: https://bugs.launchpad.net/bugs/961286
> > > > BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=903869
> > > > Signed-off-by: David Henningsson <david.henningsson@xxxxxxxxxxxxx>
> > > > Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>
> > > > [bwh: Backported to 3.2: adjust context]
> > > > Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> > >
> > > David, do I need to change this further for 3.2.y?
> >
> > Greg and Ben,
> >
> > Given some thought, the definition of is_jack_detectable has
> > changed/improved over kernels. Therefore I think it's safer not to
> > apply the patch at all for kernels earlier than 3.6. Let's revisit
> > this decision if there's actually a user demand for this fix.
>
> So should I revert this in the next 3.4 release, as it's now in the
> 3.4.35 release.

That seems to be the safest option; given that we don't get people with 
the actual hardware to test the different options and report back which 
one works best.

Sorry for the late reply.

--
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/