Re: [GIT PULL] gpio changes for v3.9; second round

From: Linus Torvalds
Date: Sun Mar 03 2013 - 13:51:04 EST


On Sat, Mar 2, 2013 at 6:24 AM, Grant Likely <grant.likely@xxxxxxxxxxxx> wrote:
>
> 2nd round of GPIO changes for Linux 3.9
>
> This branch contains a few bug fixes that I missed the first time around
> and updates to the gpio_desc series included in the first pull request.
>
> ----------------------------------------------------------------
> Gabriel Fernandez (1):
> gpio/stmpe: pass DT node to irqdomain

This breaks the build for me. I get

drivers/gpio/gpio-stmpe.c: In function âstmpe_gpio_irq_initâ:
drivers/gpio/gpio-stmpe.c:313:23: error: âstruct gpio_chipâ has no
member named âof_nodeâ
drivers/gpio/gpio-stmpe.c:316:61: error: âstruct gpio_chipâ has no
member named âof_nodeâ
drivers/gpio/gpio-stmpe.c: In function âstmpe_gpio_probeâ:
drivers/gpio/gpio-stmpe.c:351:18: error: âstruct gpio_chipâ has no
member named âof_nodeâ

and I don't think this is a merge error.

Should this driver depend on CONFIG_OF_GPIO, or should it have
#ifdef's? Regardless, it's clearly broken right now.

Unpulled.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/