Re: [PATCH 2/2] ipc: semaphores: do not hold ipc lock more thannecessary

From: Davidlohr Bueso
Date: Sat Mar 02 2013 - 16:17:10 EST


On Sat, 2013-03-02 at 12:41 +0800, Michel Lespinasse wrote:
> On Sat, Mar 2, 2013 at 8:16 AM, Davidlohr Bueso <davidlohr.bueso@xxxxxx> wrote:
> > Instead of holding the ipc lock for permissions and security
> > checks, among others, only acquire it when necessary.
> >
> > Signed-off-by: Davidlohr Bueso <davidlohr.bueso@xxxxxx>
>
> You got some really great test results on this; I think they deserve
> to be mentioned in the commit message.

Absolutely.

>
> Code looks fine to me otherwise, but I only had a quick look.
>
> Nice work!
>
> Acked-by: Michel Lespinasse <walken@xxxxxxxxxx>
>

Thanks for reviewing, Michel.

Davidlohr

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/