Re: [PATCH] <linux/of_platform.h>: fix compilation warnings withDT disabled

[Sergei Shtylyov]

Hello.

On 01-03-2013 17:48, Rob Herring wrote:

> > > > Fix the following compilation warnings (in Simon Horman's renesas.git repo):

> > > > In file included from arch/arm/mach-shmobile/setup-r8a7779.c:24:0:
> > > > include/linux/of_platform.h:107:13: warning: âstruct of_device_idâ declared
> > > > inside parameter list [enabled by default]
> > > > include/linux/of_platform.h:107:13: warning: its scope is only this definition
> > > > or declaration, which is probably not what you want [enabled by default]
> > > > include/linux/of_platform.h:107:13: warning: âstruct device_nodeâ declared
> > > > inside parameter list [enabled by default]

> > > > <linux/of_platform.h> only #include's headers with definitions of the above
> > > > mentioned structures if CONFIG_OF_DEVICE=y but uses them even if not. One
> > > > solution is to move some #include's out of #ifdef CONFIG_OF_DEVICE and use
> > > > incomplete declarations for the rest of the structures where the #ifdef move
> > > > doesn't help...

> > > > Reported-by: Vladimir Barinov <vladimir.barinov@xxxxxxxxxxxxxxxxxx>
> > > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>

> > > Reviewed-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>

> > > Grant, could you consider taking this patch?

> > Yes, I can, but I don't seem to have the original patch. Can you send it
> > again.

> Nevermind. Found it. I'll apply it.

   Will you drop 'struct device_node' declaration then or should I resend? In 
fact, I think I should better resend it with the changelog somewhat edited.

> Rob

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/