Re: [PATCH 1/2] x86: change names of e820 memory map type

From: Ingo Molnar
Date: Fri Mar 01 2013 - 05:57:17 EST



* li guang <lig.fnst@xxxxxxxxxxxxxx> wrote:

> gratuitous?
>
> It was inspired by gtk library's key definitions,

I don't think GTK is a shining example of API cleanliness and usability that the
kernel should strive to imitate, especially not in the naming department...

> gtk original keys like GDK_1, GDK_2, GDK_p, GDK_q, GDK_tab ...
> now they all be changed to GDK_KEY_1, GDK_KEY_2 ...
> do you think it's reasonable?
> or gratuitous?

I think hpa already expressed his opinion about the rename?

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/