Re: [PATCH 2/2] regulators: max8998.c: use dev_err() instead ofprintk()

[Mark Brown]

On Sat, Feb 23, 2013 at 12:51:26AM -0300, Thiago Farina wrote:
> Fixes the following checkpatch warning:
> 
> WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...

This doesn't apply against current mainline, and...

> @@ -666,7 +666,7 @@ static int max8998_pmic_probe(struct platform_device *pdev)
>  		/* Check if SET1 is not equal to 0 */
>  		if (!pdata->buck1_set1) {
>  			dev_err(&pdev->dev,
> -                                "MAX8998 SET1 GPIO defined as 0 !\n");
> +				"MAX8998 SET1 GPIO defined as 0 !\n");
>  			WARN_ON(!pdata->buck1_set1);
>  			ret = -EIO;
>  			goto err_out;

...this (which is one of the failing hunks) is an indentation change
which bears no relation to the changelog.

I've applied the final hunk which looks good but please be more careful
in future.

Attachment: signature.asc
Description: Digital signature