Re: [PATCH] backlight: atmel-pwm-bl: remove erroneous __exit annotation

From: Jingoo Han
Date: Thu Feb 28 2013 - 04:46:22 EST


On Thursday, February 28, 2013 1:05 PM, Jingoo Han wrote:
>
> CONFIG_HOTPLUG was removed, so __devexit or __exit of remove()
> should not be used.

This driver also use platform_driver_probe().
So, this patch is useless.

Please, abandon this patch.
Thank you.

Best regards,
Jingoo Han

>
> Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
> ---
> drivers/video/backlight/atmel-pwm-bl.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/backlight/atmel-pwm-bl.c b/drivers/video/backlight/atmel-pwm-bl.c
> index de5e5e7..24b90fa 100644
> --- a/drivers/video/backlight/atmel-pwm-bl.c
> +++ b/drivers/video/backlight/atmel-pwm-bl.c
> @@ -203,7 +203,7 @@ err_free_mem:
> return retval;
> }
>
> -static int __exit atmel_pwm_bl_remove(struct platform_device *pdev)
> +static int atmel_pwm_bl_remove(struct platform_device *pdev)
> {
> struct atmel_pwm_bl *pwmbl = platform_get_drvdata(pdev);
>
> @@ -222,7 +222,7 @@ static struct platform_driver atmel_pwm_bl_driver = {
> .name = "atmel-pwm-bl",
> },
> /* REVISIT add suspend() and resume() */
> - .remove = __exit_p(atmel_pwm_bl_remove),
> + .remove = atmel_pwm_bl_remove,
> };
>
> static int __init atmel_pwm_bl_init(void)
> --
> 1.7.2.5


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/