Re: [PATCH] power: make goldfish option have a dependency on goldfish

From: Geert Uytterhoeven
Date: Thu Feb 28 2013 - 01:42:36 EST

On Thu, Feb 28, 2013 at 3:59 AM, Anton Vorontsov <anton@xxxxxxxxxx> wrote:
> On Wed, Feb 27, 2013 at 09:17:06PM -0500, Paul Gortmaker wrote:
> [...]
>> > Testing patches takes time, and if I have to do it for all bunch of
>> > different machines and architectures, it becomes mess and unmanageable. In
>> So, you actually want my change then -- you do not want to test for
>> goldfish power issues unless goldfish is selected. This is how I see
>> the situation.
> No, I want to cover as much as possible code in one go. This is not 'all
> or nothing' thing, plus I can't test whether the driver actually works,
> but testing that it compiles is a great deal, because quite often patches
> just don't compile. :-)

Indeed, I agree. I also want more build coverage.

BTW, sometimes I think our reviews are better in catching logical errors than
build/configuration errors. As soon as you fix the build, it just works ;-)



Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at