Re: [PATCH 1/5] staging: android: lowmemorykiller: Add config optionto support oom_adj values

From: Arve Hjønnevåg
Date: Wed Feb 27 2013 - 20:05:10 EST

On Wed, Feb 27, 2013 at 4:14 PM, David Rientjes <rientjes@xxxxxxxxxx> wrote:
> On Wed, 27 Feb 2013, Arve Hjønnevåg wrote:
>> Because, without this patch, the values written to
>> /sys/module/lowmemorykiller/parameters/adj do not get adjusted and
>> therefore do not match the correct processes.
> Explain how this can possibly be consistent if your system includes two
> processes, one writing oom_adj values and one writing oom_score_adj
> values, and the kernel has this new option enabled?

These values are all written by the same process. If you want to
improve this, the lowmemorykiller will need a separate score_adj
parameter so that it knows for sure which type of value it receives.
You changed the meaning of /sys/module/lowmemorykiller/parameters/adj.
This patch restores the old behavior as long as the values you write
are within the range oom_adj, while still supporting the new behavior
you added in the likely case that one of the values are out of range
for oom_adj.

Arve Hjønnevåg
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at