Re: [E1000-devel] [PATCH RESEND 3/3] e1000e: fix accessing tosuspended device

From: Ben Hutchings
Date: Tue Feb 26 2013 - 18:35:30 EST

On Tue, 2013-02-26 at 14:03 +0400, Konstantin Khlebnikov wrote:
> Waskiewicz Jr, Peter P wrote:
> > On 2/24/2013 9:19 PM, Konstantin Khlebnikov wrote:
> >> This patch fixes some annoying messages like 'Error reading PHY register' and
> >> 'Hardware Erorr' and saves several seconds on reboot.
> >
> > Any networking-related patches should also include netdev@xxxxxxxxxxxxxxxx
> Yeah, I forgot about this, since I came here from PCI-bus side, not from the network =)
> >
> > I'm also a bit confused how the changes below match the patch description.
> > Elaborating a bit more how the changes suppress the messages might be a good thing.
> Patch eliminates reason of these errors -- now driver will wake up
> the device before accessing to its registers.

But e1000e calls netif_device_detach() when entering run-time suspend.
That currently prevents any ethtool operations from running until it

(This is definitely a misfeature of either the ethtool core or e1000e.
It is absolutely ridiculous that I can't check the PHY settings of an
e1000e - or even driver information! - when the link is down.)


Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at