Re: [PATCH 24/35] mfd: ab8500: Remove unnecessary 'struct device' declaration

From: Arnd Bergmann
Date: Mon Feb 25 2013 - 11:27:45 EST

On Monday 25 February 2013, Lee Jones wrote:
> > and others that use 'struct device'. C99 requires that a struct is declared
> > in advance before you use it in a function declaration.
> Hmm... I wonder why it doesn't complain then?
> I'll remove the patch.

It's only a problem if the file is included before any other header declares
'struct device'. It may well be that this currently never happens, but it's
better to be safe and have a header that can be included in any order:
relying on a specific inclusion order can easily break with 'make randconfig'
turning off specific features that you did not know you relied on.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at