Re: [PATCH] lib: devres: Fix misplaced #endif

From: Jingoo Han
Date: Sun Feb 24 2013 - 21:13:24 EST


On Saturday, February 23, 2013 6:44 AM, Andrew Morton wrote:
>
> On Fri, 22 Feb 2013 14:39:40 +0900
> Jingoo Han <jg1.han@xxxxxxxxxxx> wrote:
>
> > A misplaced #endif causes link errors related to pcim_*() functions.
> >
> > --- a/lib/devres.c
> > +++ b/lib/devres.c
> > @@ -227,6 +227,7 @@ void devm_ioport_unmap(struct device *dev, void __iomem *addr)
> > devm_ioport_map_match, (void *)addr));
> > }
> > EXPORT_SYMBOL(devm_ioport_unmap);
> > +#endif /* CONFIG_HAS_IOPORT */
> >
> > #ifdef CONFIG_PCI
> > /*
> > @@ -432,4 +433,3 @@ void pcim_iounmap_regions(struct pci_dev *pdev, int mask)
> > }
> > EXPORT_SYMBOL(pcim_iounmap_regions);
> > #endif /* CONFIG_PCI */
> > -#endif /* CONFIG_HAS_IOPORT */
>
> More details needed, please. This code is pretty old and it's
> surprising that errors are popping up now.

OK, I will add more detailed commit message.
Thank you.

Best regards,
Jingoo Han



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/