Re: [PATCH] pinctrl: return real error codes when pinctrl is not included

From: Heiko Stübner
Date: Sun Feb 24 2013 - 18:15:43 EST

Am Sonntag, 24. Februar 2013, 23:42:32 schrieb Linus Walleij:
> On Sun, Feb 24, 2013 at 11:34 PM, Heiko Stübner <heiko@xxxxxxxxx> wrote:
> > [Me]
> >
> >> This make me suspect that you have this ugly patch in some
> >> private repo and I will be seeing it again and again :-(
> >
> > All my s3c24xx work is done is my spare time, so I have to confess I came
> > up with this "ugly patch" all by myself when working on dt support for
> > my machine and stumbling upon the described problem with the pin
> > configuration.
> >
> > So, as it is obviously wrong, I also won't hold onto it.
> >
> > In any case, thanks for the thorough explanation, which I probably won't
> > forget anytime soon.
> Hm, maybe I have come across as too harsh and then I feel bad about
> that :-(
> I really want spare-time contributors, they are often more valueable
> in addition to the corporate ones since they provide an outside view
> of things.

Just to ease your mind, it didn't sound to harsh and my mail wasn't meant to
criticize (hopefully it didn't sound that way) - I am very much grateful for
the explanation.

Writing a pinctrl driver for the s3c24xx arches is still on my list, so my
understanding of pinctrl (above knowing of its existence) is not very broad
yet. With your explanation, in retrospect I can understand the ugliness of the
patch now :-) as it goes against a core principle.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at