Re: [PATCH] net: fix possible deadlock in sum_frag_mem_limit

From: David Miller
Date: Fri Feb 22 2013 - 15:14:31 EST


From: Eric Dumazet <eric.dumazet@xxxxxxxxx>
Date: Fri, 22 Feb 2013 09:43:35 -0800

> From: Eric Dumazet <edumazet@xxxxxxxxxx>
>
> Dave Jones reported a lockdep splat occurring in IP defrag code.
>
> commit 6d7b857d541ecd1d (net: use lib/percpu_counter API for
> fragmentation mem accounting) added a possible deadlock.
>
> Because percpu_counter_sum_positive() needs to acquire
> a lock that can be used from softirq, we need to disable BH
> in sum_frag_mem_limit()
>
> Reported-by: Dave Jones <davej@xxxxxxxxxx>
> Signed-off-by: Eric Dumazet <edumazet@xxxxxxxxxx>
> Cc: Jesper Dangaard Brouer <brouer@xxxxxxxxxx>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/