Re: [PATCH v4] mfd: syscon: Add non-DT support
From: Alexander Shiyan
Date: Fri Feb 22 2013 - 02:01:25 EST
> On Thu, Feb 21, 2013 at 07:29:02PM +0400, Alexander Shiyan wrote:
> > This patch allow using syscon driver from the platform data, i.e.
> > possibility using driver on systems without oftree support.
> > For search syscon device from the client drivers,
> > "syscon_regmap_lookup_by_pdevname" function was added.
> > Signed-off-by: Alexander Shiyan <shc_work@xxxxxxx>
> > + syscon->base = devm_ioremap_resource(dev, res);
> > + if (!syscon->base)
> Is this correct?
Hmm, of course IS_ERR should be used here...
> > + return -EBUSY;
> Otherwise, i'm also ok with this patch.
> Acked-by: Dong Aisheng <dong.aisheng@xxxxxxxxxx>
> BTW, i did not see Samuel's tree having this new API.
> So, who will pick this patch?
I have same question.