Re: [RFC/PATCH 2/5] kernel_cpustat: convert to atomic 64-bit accessors
From: Kevin Hilman
Date: Fri Feb 22 2013 - 00:57:57 EST
Frederic Weisbecker <fweisbec@xxxxxxxxx> writes:
> 2013/2/21 Frederic Weisbecker <fweisbec@xxxxxxxxx>:
>> 2013/2/21 Kevin Hilman <khilman@xxxxxxxxxx>:
>>> Subject: [PATCH 2/5] kernel_cpustat: convert to atomic 64-bit accessors
>>> Use the atomic64_* accessors for all the kernel_cpustat fields to
>>> ensure atomic access on non-64 bit platforms.
>>> Thanks to Mats Liljegren for CGROUP_CPUACCT related fixes.
>>> Cc: Mats Liljegren <mats.liljegren@xxxxxxxx>
>>> Signed-off-by: Kevin Hilman <khilman@xxxxxxxxxx>
>> Funny stuff, I thought struct kernel_cpustat was made of cputime_t
>> field. Actually it's u64. So the issue is independant from the new
>> full dynticks cputime accounting. It was already broken before.
>> But yeah that's not the point, we still want to fix this anyway. But
>> let's just treat this patch as independant.
OK, I just sent an updated series based on your proposal.
Thanks for the review,
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/